Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19243#discussion_r139601709 --- Diff: R/pkg/R/DataFrame.R --- @@ -984,12 +984,12 @@ setMethod("unique", #' of the total count of of the given SparkDataFrame. #' #' @param x A SparkDataFrame -#' @param withReplacement Sampling with replacement or not +#' @param withReplacement Sampling with replacement or not. Default is \code{FALSE}. --- End diff -- we actually want to change to not documenting the default value if it is already in the signature - because then it would be the roxygen2 generated doc
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org