Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19020#discussion_r139772375
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -471,6 +574,15 @@ object LinearRegression extends
DefaultParamsReadable[LinearRegression] {
/** Set of solvers that LinearRegression supports. */
private[regression] val supportedSolvers = Array(Auto, Normal, LBFGS)
+
+ /** String name for "leastSquares". */
+ private[regression] val LeastSquares = "leastSquares"
--- End diff --
How about calling this "squaredError" since the loss is "squared error,"
not "least squares."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
