Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2241#discussion_r18496664
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -287,22 +289,20 @@ class HiveContext(sc: SparkContext) extends 
SQLContext(sc) {
           val cmd_trimmed: String = cmd.trim()
           val tokens: Array[String] = cmd_trimmed.split("\\s+")
           val cmd_1: String = cmd_trimmed.substring(tokens(0).length()).trim()
    -      val proc: CommandProcessor = CommandProcessorFactory.get(tokens(0), 
hiveconf)
    +      val proc: CommandProcessor = 
HiveShim.getCommandProcessor(Array(tokens(0)), hiveconf)
     
           proc match {
             case driver: Driver =>
    -          driver.init()
    -
               val results = new JArrayList[String]
    --- End diff --
    
    Need consider compatibility here since ```driver.getResults(results)``` api 
changed in hive-0.13.1. You can refer my change 
there(https://github.com/scwf/spark/blob/hive-0.13.1-clean/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala#L295-L310)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to