Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2513#discussion_r18496850
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/CacheManager.scala
---
@@ -91,14 +91,10 @@ private[sql] trait CacheManager {
}
/** Removes the data for the given SchemaRDD from the cache */
- private[sql] def uncacheQuery(query: SchemaRDD, blocking: Boolean =
false): Unit = writeLock {
+ private[sql] def uncacheQuery(query: SchemaRDD, blocking: Boolean =
true): Unit = writeLock {
--- End diff --
@marmbrus Forgot to confirm this with you: default value of the `blocking`
argument is `true` in `RDD.unpersist()`, I changed the default value here to
keep the semantics consistent. This also makes testing more easily (I added
assertions to check RDD materialization, non-blocking unpersisting introduces
some subtleties). Did you intend to use non-blocking unpersisting here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
