GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19290
[WIP][SPARK-22063][R] Upgrades lintr to latest commit sha1 ID
## What changes were proposed in this pull request?
Currently, we set lintr to `jimhester/lintr@a769c0b` (see
[this](https://github.com/apache/spark/commit/7d1175011c976756efcd4e4e4f70a8fd6f287026)
and [SPARK-14074](https://issues.apache.org/jira/browse/SPARK-14074)).
I first tested and checked lintr-1.0.1 but it looks many important fixes
are missing (for example, checking 100 length). So, I decided to propose it
with the sha1 to
https://github.com/jimhester/lintr/commit/5431140ffea65071f1327625d4a8de9688fa7e72.
It looks it has fixed many bugs and now finds many instances that I have
observed and thought should be caught time to time, here I filed [the
results](https://gist.github.com/HyukjinKwon/4f59ddcc7b6487a02da81800baca533c).
The downside looks it now takes about 7ish mins, (it was 2ish mins before).
## How was this patch tested?
Manually, `./dev/lint-r` after manually updating the lintr package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark upgrade-r-lint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19290
----
commit 6e41eff8334e0ce87841941d34fb9b88751f1705
Author: hyukjinkwon <[email protected]>
Date: 2017-09-19T15:51:23Z
Upgrade lintr to latest commit sha1 ID
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
