Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/19271#discussion_r139891727
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
---
@@ -114,6 +115,16 @@ class IncrementalExecution(
stateInfo = Some(nextStatefulOperationStateInfo),
batchTimestampMs = Some(offsetSeqMetadata.batchTimestampMs),
eventTimeWatermark = Some(offsetSeqMetadata.batchWatermarkMs))
+
+ case j @ StreamingSymmetricHashJoinExec(lKeys, rKeys, _, cond, _, _,
_, left, right) =>
--- End diff --
nit: when there are so many values you're using out of
`StreamingSymmetricHashJoinExec`, this piece of code may be easier to maintain
if you just use `j: StreamingSymmetricHashJoinExec` instead. Otherwise, if we
add one more field to this thing, then we're going to hit 100 chars per line
scalastyle issue.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
