Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r140117055
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -198,16 +198,19 @@ private[spark] class 
MesosCoarseGrainedSchedulerBackend(
           sc.conf.getOption("spark.mesos.driver.frameworkId").map(_ + suffix)
         )
     
    -    if (principal != null) {
    +    // check that the credentials are defined, even though it's likely 
that auth would have failed
    +    // already if you've made it this far
    +    if (principal != null && hadoopDelegationCreds.isDefined) {
           logDebug(s"Principal found ($principal) starting token renewer")
           val credentialRenewerThread = new Thread {
             setName("MesosCredentialRenewer")
             override def run(): Unit = {
    +          val dummy: Option[Array[Byte]] = None
    --- End diff --
    
    What is this for?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to