Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r140142353
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -230,21 +230,19 @@ private[ml] object ProbabilisticClassificationModel {
* Normalize a vector of raw predictions to be a multinomial probability
vector, in place.
*
* The input raw predictions should be nonnegative.
- * The output vector sums to 1, unless the input vector is all-0 (in
which case the output is
- * all-0 too).
+ * The output vector sums to 1, when the input vector is all-0,
exception will be thrown.
--- End diff --
This isn't grammatical. You might just move the new note to a proper throws
tag in the scaladoc here anyway
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
