Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19307#discussion_r140210528
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2826,33 +2826,33 @@ object WritableConverter {
// them automatically. However, we still keep the old functions in
SparkContext for backward
// compatibility and forward to the following functions directly.
- implicit def intWritableConverter(): WritableConverter[Int] =
- simpleWritableConverter[Int, IntWritable](_.get)
+ implicit val intWritableConverter: () => WritableConverter[Int] =
--- End diff --
These changes were necessary to make the implicits work in 2.12 now that
eta-expansion of zero-arg methods is deprecated and apparently doesn't work for
implicit resolution. It passes MiMa, but we could be conservative and retain
the existing methods, and add function vals instead.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]