Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19302#discussion_r140212665
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ---
    @@ -533,20 +533,30 @@ object StringTrim {
     @ExpressionDescription(
       usage = """
         _FUNC_(str) - Removes the leading and trailing space characters from 
`str`.
    -    _FUNC_(BOTH trimStr FROM str) - Remove the leading and trailing 
trimString from `str`
    +    _FUNC_(BOTH trimStr FROM str) - Remove the leading and trailing 
`trimStr` characters from `str`
    +    _FUNC_(LEADING trimStr FROM str) - Remove the leading `trimStr` 
characters from `str`
    +    _FUNC_(TRAILING trimStr FROM str) - Remove the trailing `trimStr` 
characters from `str`
    --- End diff --
    
    I'd fold those lines into one if possible. If that looks quite messed, we 
could add each extra newline between `_FUNC_(...)`s. Currently, the doc is 
rendered as below:
    
    ![2017-09-21 3 33 
09](https://user-images.githubusercontent.com/6477701/30693144-414283bc-9f09-11e7-86d0-52e2cfe83c4e.png)



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to