Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
To @shivaram:
> does that also happen with lintr-1.0.1 ? I wonder if we are seeing some
specific performance slowdown because of not using a release (it might be good
to follow up with lint-r authors if that is the case ?)
I just ran it with lintr-1.0.1. This took 2ish mins in my local, which is
almost identical with the current, jimhester/lintr@a769c0b. Will open up an
issue there and ask this in their repo tomorrow _(pending ..)_.
</br>
</br>
To @felixcheung:
> 5 min: this is mildly concerning, is it possible this is caused by new
checks in lintr? perhaps we could exclude them or something?
I tried to disable all the linters documented in
https://github.com/jimhester/lintr/blob/master/README.md#available-linters:
```diff
diff --git a/R/pkg/.lintr b/R/pkg/.lintr
index ae50b28ec61..ca1efcfacc7 100644
--- a/R/pkg/.lintr
+++ b/R/pkg/.lintr
@@ -1,2 +1,2 @@
-linters: with_defaults(line_length_linter(100), multiple_dots_linter =
NULL, camel_case_linter = NULL, open_curly_linter(allow_single_line = TRUE),
closed_curly_linter(allow_single_line = TRUE))
+linters: with_defaults(commas_linter = NULL, object_usage_linter = NULL,
absolute_path_linter = NULL, nonportable_path_linter = NULL,
pipe_continuation_linter = NULL, assignment_linter = NULL, closed_curly_linter
= NULL, extraction_operator_linter = NULL, implicit_integer_linter = NULL,
infix_spaces_linter = NULL, line_length_linter = NULL, no_tab_linter = NULL,
object_length_linter = NULL, object_name_linter = NULL, open_curly_linter =
NULL, semicolon_terminator_linter = NULL, single_quotes_linter = NULL,
spaces_inside_linter = NULL, spaces_left_parentheses_linter = NULL,
todo_comment_linter = NULL, trailing_blank_lines_linter = NULL,
trailing_whitespace_linter = NULL, T_and_F_symbol_linter = NULL,
undesirable_function_linter = NULL, undesirable_operator_linter = NULL,
unneeded_concatenation_linter = NULL)
exclusions: list("inst/profile/general.R" = 1, "inst/profile/shell.R")
```
and this took 1.5 mins. Looks we could identify some linters that we might
not need. Let me check this one tomorrow _(pending ..)_
> lintr version: I see what you say about 1.0.1. According this commit list
https://github.com/jimhester/lintr/commits/master the tag for 1.0.1 vs the
latest (the git tag you are using) are different only by some insignificant
changes?
Diff looks 122 commits -
https://github.com/jimhester/lintr/compare/v1.0.1...master . Will take a look
though the commit logs _(pending ..)_
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
