Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/19271
LGTM: Would love to see the following things a bit more buttoned up in a
follow up PR:
1. Tests on join + aggregation and aggregation + join
2. A better, safer, more understandable handling of [this
line](https://github.com/apache/spark/pull/19271/files#diff-8e18a76135ded4a7998d28013c02b1a2R182).
Getting the watermark out of a window function is too fragile at the moment,
and I think it could fail if you would put had a structure such as:
```
timestamps: struct {
eventTime,
ingestTime,
processingTime
}
```
and you had set a watermark on `timestamps.eventTime`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
