Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19278#discussion_r140373339
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -396,17 +396,24 @@ private[ml] object DefaultParamsReader {
/**
* Extract Params from metadata, and set them in the instance.
- * This works if all Params implement
[[org.apache.spark.ml.param.Param.jsonDecode()]].
+ * This works if all Params (except params included by `skipParams`
list) implement
+ * [[org.apache.spark.ml.param.Param.jsonDecode()]].
+ *
+ * The params included in `skipParams` won't be set. This is useful if
some params don't
+ * implement [[org.apache.spark.ml.param.Param.jsonDecode()]] and need
special handling.
* TODO: Move to [[Metadata]] method
*/
- def getAndSetParams(instance: Params, metadata: Metadata): Unit = {
+ def getAndSetParams(instance: Params, metadata: Metadata,
--- End diff --
fix scala style: 1 arg per line for multiline declarations
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
