Github user ConeyLiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19316#discussion_r140408116
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -387,11 +387,18 @@ private[spark] class MemoryStore(
// the block's actual memory usage has exceeded the unroll memory by a
small amount, so we
// perform one final call to attempt to allocate additional memory if
necessary.
if (keepUnrolling) {
- serializationStream.close()
- reserveAdditionalMemoryIfNecessary()
+ serializationStream.flush()
+ if (bbos.size > unrollMemoryUsedByThisBlock) {
+ val amountToRequest = bbos.size - unrollMemoryUsedByThisBlock
--- End diff --
Here, we only need request the `bbos.size - unrollMemoryUsedByThisBlock`.
I'm sorry, this mistake maybe introduced by my previous patch
[SPARK-21923](https://github.com/apache/spark/pull/19135).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
