Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19312#discussion_r140425239
--- Diff: dev/create-release/release-build.sh ---
@@ -95,6 +95,28 @@ if [ -z "$SPARK_VERSION" ]; then
| grep -v INFO | grep -v WARNING | grep -v Download)
fi
+# Verify we have the right java version set
+java_version=$("${JAVA_HOME}"/bin/javac -version 2>&1 | cut -d " " -f 2)
--- End diff --
Thanks. The logic we use in make-distribution to resolve JAVA_HOME when not
set is a bit more complicated, but I think for the release script its
reasonable (and probably a good practice) to explicitly require a JAVA_HOME to
be set so I'll go with the first of the 2.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
