Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2692#discussion_r18529676
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/columnar/PartitionBatchPruningSuite.scala
 ---
    @@ -67,10 +67,11 @@ class PartitionBatchPruningSuite extends FunSuite with 
BeforeAndAfterAll with Be
       checkBatchPruning("i > 8 AND i <= 21", 9 to 21, 2, 3)
       checkBatchPruning("i < 2 OR i > 99", Seq(1, 100), 2, 2)
       checkBatchPruning("i < 2 OR (i > 78 AND i < 92)", Seq(1) ++ (79 to 91), 
3, 4)
    +  checkBatchPruning("NOT (i < 88)", 88 to 100, 1, 2)
     
       // With unsupported predicate
       checkBatchPruning("i < 12 AND i IS NOT NULL", 1 to 11, 1, 2)
    -  checkBatchPruning("NOT (i < 88)", 88 to 100, 5, 10)
    +  checkBatchPruning("NOT (i in (1))", 2 to 100, 5, 10)
    --- End diff --
    
    How about 
    ```
    checkBatchPruning(s"NOT (i in (${(1 to 30).mkString(",")}))", 31 to 100, 5, 
10)
    ```
    For this case, we will read 4 partitions including 7 batches when we can 
support it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to