Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18532610
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -205,10 +231,74 @@ private[spark] object JettyUtils extends Logging {
ServerInfo(server, boundPort, collection)
}
+ // to generate a new url string scheme://server:port+path
--- End diff --
Hi @scwf,
The reason I asked for a comment is that it seems like the method is doing
a little more than just that. For example, L238 seems to be doing some sort of
parsing of the `server` string, so it's more than just concatenating the
different arguments into a URL.
It would be nice if the comment explained exactly what the relationship
between the input and the output is. A unit test wouldn't hurt either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
