Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19286#discussion_r140638128
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -749,6 +749,34 @@ class JDBCSuite extends SparkFunSuite
assert(agg.isCascadingTruncateTable() === Some(true))
}
+ test("Aggregated dialects: isCascadingTruncateTable") {
+ def genDialect(cascadingTruncateTable: Option[Boolean]): JdbcDialect =
new JdbcDialect {
+ override def canHandle(url: String): Boolean = true
+ override def getCatalystType(
+ sqlType: Int,
+ typeName: String,
+ size: Int,
+ md: MetadataBuilder): Option[DataType] = None
+ override def isCascadingTruncateTable(): Option[Boolean] =
cascadingTruncateTable
+ }
+
+ val dialectCombination = Seq(
+ List(genDialect(Some(true)), genDialect(Some(false)),
genDialect(None)),
+ List(genDialect(Some(true)), genDialect(Some(true)),
genDialect(None)),
+ List(genDialect(Some(false)), genDialect(Some(false)),
genDialect(None)),
+ List(genDialect(Some(true)), genDialect(Some(true))),
+ List(genDialect(Some(false)), genDialect(Some(false))),
+ List(genDialect(None), genDialect(None))
+ )
+
+ val expectedCascading = Seq(Some(true), Some(true), None, Some(true),
Some(false), None)
+
+ dialectCombination.zip(expectedCascading).foreach { case (dialects,
cascading) =>
--- End diff --
Could we combine `dialectCombination` and `expectedCascading` together? Or
we can create a separate helper function?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
