Github user sathiyapk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19295#discussion_r140652720
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala ---
    @@ -44,11 +44,14 @@ class ExperimentalMethods private[sql]() {
        */
       @volatile var extraStrategies: Seq[Strategy] = Nil
     
    +  @volatile var extraPreOptimizations: Seq[Rule[LogicalPlan]] = Nil
    +
       @volatile var extraOptimizations: Seq[Rule[LogicalPlan]] = Nil
    --- End diff --
    
    Yes, i agree with @gatorsmile, renaming `extraOptimizations ` to 
`extraPostOptimizations` will be symmetric with `extraPreOptimizations`, but 
doing so may affect the existing API calls.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to