Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2681#discussion_r18534919
  
    --- Diff: 
core/src/test/scala/org/apache/spark/broadcast/BroadcastSuite.scala ---
    @@ -257,7 +257,7 @@ class BroadcastSuite extends FunSuite with 
LocalSparkContext {
           new SparkContext("local", "test", broadcastConf)
         }
         val blockManagerMaster = sc.env.blockManager.master
    -    val list = List[Int](1, 2, 3, 4)
    +    val list = (1 to 4096).toList
    --- End diff --
    
    can u make sure we have unit tests for both cases? i.e. small broadcast and 
large ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to