Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19324#discussion_r141031904 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -599,10 +621,14 @@ case class HashAggregateExec( } } else "" } + ctx.addExtraCode(generateGenerateCode()) --- End diff -- just for curiosity, is it really worth to codegen the fast hash map?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org