Github user juliuszsompolski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19324#discussion_r141039074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -201,11 +201,14 @@ case class FilterExec(condition: Expression, child:
SparkPlan)
ev
}
+ // Note: wrap in "do { } while(false);", so the generated checks can
jump out with "continue;"
--- End diff --
`genPredicate` and `generated` ~50 lines above would have to be rewritten
to now use `continue`. As you pointed in a previous comment, that would
potentially lead to very nested scopes. Shouldn't be a problem for the
compiler; for code generation the `genPredicate` would have to maintain these
scopes and where to end them - i.e. wherever it not places a `continue`, it
would have to open a nested scope, and then it would have to be closed in a
correct place.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
