Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2612#discussion_r18541644
--- Diff: dev/lint-windows-cmd ---
@@ -0,0 +1,40 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
+SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"
+TARGET_DIR="$SPARK_ROOT_DIR/bin"
+HAS_ERROR=0
+
+# check whether all of lines ends with CRLF.
+for file in "$TARGET_DIR"/*.cmd ; do
+ grep "^.*"$'\r'"$" "$file" &> /dev/null
--- End diff --
Is there a simpler way to write this? It would also be good to show which
lines had CR/LF endings, if any. This would match what our other style checks
do.
For example, I suggest something like:
```
grep -v -nU $'\r' *.cmd > ./lint-windows-cmd.log
if [ "$?" -eq 0 ]; then
echo "Windows batch file style checks failed."
echo "Non-Windows-style line endings were found at the following
locations:"
cat ./lint-windows-cmd.log
echo "Please fix the line endings to follow the Windows convention of
CR/LF."
else
echo "Windows batch file style checks passed."
fi
rm ./lint-windows-cmd.log
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
