Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19368#discussion_r141394216
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
    @@ -274,4 +274,16 @@ class OrcSourceSuite extends OrcSuite {
           )).get.toString
         }
       }
    +
    +  test("SPARK-22146: read ORC files containing special characters") {
    --- End diff --
    
    Hi @dongjoon-hyun,
    thank you for your review.
    My only concern is that while ORC support is in the hive module, all the 
other datasources are in the sql module. So, where should we put the 
generalized test?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to