Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19362#discussion_r141403817
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -136,6 +134,8 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
         Batch("LocalRelation", fixedPoint,
           ConvertToLocalRelation,
           PropagateEmptyRelation) ::
    +    Batch("Check Cartesian Products", Once,
    --- End diff --
    
    we should also add a comment here about the positioning ...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to