Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141510861
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -74,6 +81,10 @@ class TaskInfo(
gettingResultTime = time
}
+ private[spark] def markKilledAttempt: Unit = {
--- End diff --
I think I suggested you to add parenthesis in this method signature `def
markKilledByOtherAttempt()`, can you please change it?
> It is better to change the method signature to def
markKilledByOtherAttempt(): Unit = {, since this method has side affect, it is
better to add parenthesis.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
