Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19364#discussion_r141784391
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ExchangeCoordinator.scala
 ---
    @@ -232,7 +232,7 @@ class ExchangeCoordinator(
           // number of post-shuffle partitions.
           val partitionStartIndices =
             if (mapOutputStatistics.length == 0) {
    -          None
    +          Some(Array[Int]())
    --- End diff --
    
    I meant;
    ```
          val partitionStartIndices =
            if (mapOutputStatistics.length == 0) {
               Array.empty[Int]
            } else {
              estimatePartitionStartIndices(mapOutputStatistics)
            }
    
          ...
              exchange.preparePostShuffleRDD(shuffleDependencies(k), 
Some(partitionStartIndices))
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to