Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19181#discussion_r141892238
  
    --- Diff: 
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java
 ---
    @@ -139,4 +139,44 @@ public int compare(
         }
         assertEquals(dataToSort.length, iterLength);
       }
    +
    +  @Test
    +  public void freeAfterOOM() {
    +    final TestMemoryManager testMemoryManager = new TestMemoryManager(new 
SparkConf().set("spark.memory.offHeap.enabled", "false"));
    --- End diff --
    
    nit: Is it better to wrap this line since this is too long.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to