Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19382#discussion_r141908151
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1438,39 +1438,44 @@ class HiveDDLSuite
}
test("create hive serde table with new syntax") {
- withTable("t", "t2", "t3") {
- withTempPath { path =>
- sql(
- s"""
- |CREATE TABLE t(id int) USING hive
- |OPTIONS(fileFormat 'orc', compression 'Zlib')
- |LOCATION '${path.toURI}'
- """.stripMargin)
- val table =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
- assert(DDLUtils.isHiveTable(table))
- assert(table.storage.serde ==
Some("org.apache.hadoop.hive.ql.io.orc.OrcSerde"))
- assert(table.storage.properties.get("compression") == Some("Zlib"))
- assert(spark.table("t").collect().isEmpty)
-
- sql("INSERT INTO t SELECT 1")
- checkAnswer(spark.table("t"), Row(1))
- // Check if this is compressed as ZLIB.
- val maybeOrcFile =
path.listFiles().find(!_.getName.endsWith(".crc"))
- assert(maybeOrcFile.isDefined)
- val orcFilePath = maybeOrcFile.get.toPath.toString
- val expectedCompressionKind =
- OrcFileOperator.getFileReader(orcFilePath).get.getCompression
- assert("ZLIB" === expectedCompressionKind.name())
-
- sql("CREATE TABLE t2 USING HIVE AS SELECT 1 AS c1, 'a' AS c2")
- val table2 =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t2"))
- assert(DDLUtils.isHiveTable(table2))
- assert(table2.storage.serde ==
Some("org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe"))
- checkAnswer(spark.table("t2"), Row(1, "a"))
-
- sql("CREATE TABLE t3(a int, p int) USING hive PARTITIONED BY (p)")
- sql("INSERT INTO t3 PARTITION(p=1) SELECT 0")
- checkAnswer(spark.table("t3"), Row(0, 1))
+ Seq("true", "false").foreach { value =>
+ withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> value) {
+ withTable("t", "t2", "t3") {
+ withTempPath { path =>
+ sql(
+ s"""
+ |CREATE TABLE t(id int) USING hive
+ |OPTIONS(fileFormat 'orc', compression 'Zlib')
--- End diff --
Thank you for review, @gatorsmile . I'll check that, too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
