Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19401#discussion_r142018469 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -238,7 +238,7 @@ class Dataset[T] private[sql]( private[sql] def showString( _numRows: Int, truncate: Int = 20, vertical: Boolean = false): String = { val numRows = _numRows.max(0) - val takeResult = toDF().take(numRows + 1) + val takeResult = toDF().take(if (numRows == Int.MaxValue) numRows else numRows + 1) --- End diff -- yea, looks great. I updated.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org