Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17673#discussion_r142219791
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
    @@ -76,6 +76,49 @@ class Word2VecSuite extends SparkFunSuite with 
MLlibTestSparkContext with Defaul
         }
       }
     
    +  test("Word2Vec-CBOW") {
    --- End diff --
    
    I feel like there is a lot of duplication in the Word2Vec tests now. It 
would be ok to do as a follow up, but I think things can be cleaned up a lot 
here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to