Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19419#discussion_r142409684
  
    --- Diff: conf/spark-defaults.conf.template ---
    @@ -19,9 +19,16 @@
     # This is useful for setting default environmental settings.
     
     # Example:
    -# spark.master                     spark://master:7077
    -# spark.eventLog.enabled           true
    -# spark.eventLog.dir               hdfs://namenode:8021/directory
    -# spark.serializer                 
org.apache.spark.serializer.KryoSerializer
    -# spark.driver.memory              5g
    -# spark.executor.extraJavaOptions  -XX:+PrintGCDetails -Dkey=value 
-Dnumbers="one two three"
    +# spark.master                          spark://master:7077
    +# spark.eventLog.enabled                true
    +# spark.eventLog.dir                    hdfs://namenode:8021/directory
    +# spark.serializer                      
org.apache.spark.serializer.KryoSerializer
    +# spark.driver.memory                   5g
    +# spark.executor.extraJavaOptions       -XX:+PrintGCDetails -Dkey=value 
-Dnumbers="one two three"
    +
    +#spark.ui.allowFramingFrom              https://example.com/
    +#spark.ui.xXssProtection.enabled        1; mode=block
    --- End diff --
    
    This sounds like a boolean flag but its value isn't boolean; if it has only 
one reasonable value then it can be a boolean that sets that value. Otherwise 
maybe call the property something else


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to