Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19405#discussion_r142450897
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetadataCacheSuite.scala 
---
    @@ -31,14 +31,22 @@ import org.apache.spark.sql.test.SQLTestUtils
     class HiveMetadataCacheSuite extends QueryTest with SQLTestUtils with 
TestHiveSingleton {
     
       test("SPARK-16337 temporary view refresh") {
    -    withTempView("view_refresh") {
    +    checkRefreshView(isTemp = true)
    +  }
    +
    +  test("view refresh") {
    --- End diff --
    
    Yes. We need to ask contributors for adding more test cases when reviewing 
the PR. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to