Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r142571603
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,36 +462,55 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
val expElogbetaBc = batch.sparkContext.broadcast(expElogbeta)
val alpha = this.alpha.asBreeze
val gammaShape = this.gammaShape
+ val optimizeDocConcentration = this.optimizeDocConcentration
+ // We calculate logphat in the same pass as other statistics, but we
only need
+ // it if we are optimizing docConcentration
--- End diff --
The comment is not that accurate. If `optimizeDocConcentration==false`,
logphat will not be calculated.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
