Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19369#discussion_r142896027
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -67,7 +67,7 @@ private[spark] class DiskStore(
var threwException: Boolean = true
try {
writeFunc(out)
- blockSizes.put(blockId.name, out.getCount)
+ blockSizes.put(blockId, out.getCount)
--- End diff --
@superbobry I think the last test failure is legit as you need to update
the call to remove(blockId.name) on about line 116.
I was surprised it even compiles, but, for legacy reasons the JDK
collections classes don't have generic types on methods like remove, so it
accepts any object. That however should be the last change here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
