Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19447#discussion_r143204826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -279,11 +279,13 @@ class CodegenContext {
inlineToOuterClass: Boolean = false): String = {
// The number of named constants that can exist in the class is
limited by the Constant Pool
// limit, 65,536. We cannot know how many constants will be inserted
for a class, so we use a
- // threshold of 1600k bytes to determine when a function should be
inlined to a private, nested
- // sub-class.
+ // threshold to determine when a function should be inlined to a
private, nested sub-class
+ val generatedClassLengthThreshold = SparkEnv.get.conf.getInt(
--- End diff --
Can this be empty? In
https://github.com/apache/spark/blob/83488cc3180ca18f829516f550766efb3095881e/sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java#L80
there is no check about it being `None`...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
