Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19438#discussion_r143331525
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
 ---
    @@ -58,7 +58,7 @@ class QuantileSummariesSuite extends SparkFunSuite {
         if (data.nonEmpty) {
           val approx = summary.query(quant).get
           // The rank of the approximation.
    -      val rank = data.count(_ < approx) // has to be <, not <= to be exact
    +      val rank = data.count(_ <= approx)
    --- End diff --
    
    Without this change, four test cases failed:
    1. Merging ordered lists with epsi=0.1 and seq=increasing, compression=1000
    2. Merging ordered lists with epsi=0.1 and seq=increasing, compression=10
    3. Merging ordered lists with epsi=0.1 and seq=decreasing, compression=1000
    4. Merging ordered lists with epsi=0.1 and seq=decreasing, compression=10


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to