Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143481416
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite extends SparkFunSuite {
if (data.nonEmpty) {
val approx = summary.query(quant).get
// The rank of the approximation.
- val rank = data.count(_ < approx) // has to be <, not <= to be exact
+ val rank = data.count(_ <= approx)
--- End diff --
Or I can get the rank as follows, then the tests can pass:
```
val minRank = data.count(_ < approx)
val maxRank = data.count(_ <= approx)
val rank = if (maxRank - minRank > 1) (minRank + maxRank) / 2 else
maxRank
```
what do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
