Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19399#discussion_r143589483
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -850,6 +869,18 @@ private[history] class AppListingListener(log: 
FileStatus, clock: Clock) extends
             fileSize)
         }
     
    +    def applicationStatus : Option[String] = {
    --- End diff --
    
    Why returning `Option[String]` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to