Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19082
To my best guess, trying to make huge method by method inlining will not
fail JIT compilation in Hotspot. It may fail method inlining.
According to these blog entries
[1](https://techblug.wordpress.com/2013/08/19/java-jit-compiler-inlining/), [2](
http://normanmaurer.me/blog/2014/05/15/Inline-all-the-Things/), we can see
the following annotations for method inlining (explanations from [1])
1. **inline (hot)**: the method was determined hot and inlined
2. **too big**: the method was not inlined as the generated code was
getting too big (but the method was not hot)
3. **hot method too big**: the method was determined hot but not inlined
because the resulting code was getting too big.
Annotation 1. shows that inlining are suceeded. Annotation 2. or 3. shows
that callee is too large. While 2. or 3. is shown in the compilation log [2],
it still seems to succeed to compile a method. Of course, some method inling is
are disabled.
[Here](https://issues.apache.org/jira/browse/HBASE-15431) is an interesting
experiments. While they forced to inlining by increasing threshold, it is not
easy to see performance improvement.
@viirya, is it answer to your question?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
