Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19270#discussion_r143861205
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
    @@ -46,3 +46,84 @@ function formatBytes(bytes, type) {
         var i = Math.floor(Math.log(bytes) / Math.log(k));
         return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + 
sizes[i];
     }
    +
    +function formatLogsCells(execLogs, type) {
    +    if (type !== 'display') return Object.keys(execLogs);
    +    if (!execLogs) return;
    +    var result = '';
    +    $.each(execLogs, function (logName, logUrl) {
    +        result += '<div><a href=' + logUrl + '>' + logName + '</a></div>'
    +    });
    +    return result;
    +}
    +
    +function getStandAloneAppId() {
    +    var words = document.baseURI.split('/');
    +    var ind = words.indexOf("proxy");
    +    if (ind > 0) {
    +        var appId = words[ind + 1];
    +        return appId;
    +    }
    +    ind = words.indexOf("history");
    +    if (ind > 0) {
    +        var appId = words[ind + 1];
    +        return appId;
    +    }
    +    //Looks like Web UI is running in standalone mode
    +    //Let's get application-id using REST End Point
    +    $.getJSON(location.origin + "/api/v1/applications", function(response, 
status, jqXHR) {
    +        if (response && response.length > 0) {
    +            var appId = response[0].id
    +            return appId;
    --- End diff --
    
    Since this is inside a getJSON this value will never return. This line here 
is why this function took in a function before. So we'll need to change it back.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to