Github user ConeyLiu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19316#discussion_r143901552
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -388,7 +388,13 @@ private[spark] class MemoryStore(
         // perform one final call to attempt to allocate additional memory if 
necessary.
         if (keepUnrolling) {
    --- End diff --
    
    We maybe need request the extra-memory (`bbos.size - 
unrollMemoryUsedByThisBlock`). So the `keepUnrolling` maybe change in line 393.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to