Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r144136759 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1242,6 +1243,57 @@ object ReplaceIntersectWithSemiJoin extends Rule[LogicalPlan] { } /** + * If one or both of the datasets in the logical [[Except]] operator are purely transformed using + * [[Filter]], this rule will replace logical [[Except]] operator with a [[Filter]] operator by + * flipping the filter condition of the right child. + * {{{ + * SELECT a1, a2 FROM Tab1 WHERE a2 = 12 EXCEPT SELECT a1, a2 FROM Tab1 WHERE a1 = 5 + * ==> SELECT DISTINCT a1, a2 FROM Tab1 WHERE a2 = 12 AND a1 <> 5 + * }}} + * + * Note: + * 1. We should combine all the [[Filter]] of the right node before flipping it using NOT operator. + */ +object ReplaceExceptWithFilter extends Rule[LogicalPlan] { + + import scala.annotation.tailrec --- End diff -- maybe put this import to the beginning of file?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org