Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Thanks for the review @brkyvz .
Please have a look at the new PR. I have implemented the review comments.
For the API hygiene, I have added both the new and old API, and have marked
the old API as deprecated. The rational behind keeping the new API is to
support any future changes to the Kinesis consumer lib, and we could just add
new case classes in one place to handle new params. Otherwise we would have to
keep adding new arguments to the kinesis receiver function. The New api also
makes it clear to understand what exactly is the purpose of the arguments.
I have also added new test cases to test the old api with both +ve and -ve
scenarios.
Please have a look and share your thoughts.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
