Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18664#discussion_r144148579
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -31,7 +31,8 @@ object ArrowUtils {
// todo: support more types.
- def toArrowType(dt: DataType): ArrowType = dt match {
+ /** Maps data type from Spark to Arrow. NOTE: timeZoneId required for
TimestampTypes */
+ def toArrowType(dt: DataType, timeZoneId: Option[String]): ArrowType =
dt match {
--- End diff --
Btw, why don't we set default values for `timeZoneId`? Seems a bit weird
having to specify `None` for other types.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
