Github user fjh100456 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19218#discussion_r144202674
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
    @@ -728,4 +732,254 @@ class InsertSuite extends QueryTest with 
TestHiveSingleton with BeforeAndAfter
           assert(e.contains("mismatched input 'ROW'"))
         }
       }
    +
    +  private def getConvertMetastoreConfName(format: String): String = format 
match {
    +    case "parquet" => "spark.sql.hive.convertMetastoreParquet"
    +    case "orc" => "spark.sql.hive.convertMetastoreOrc"
    +  }
    +
    +  private def getSparkCompressionConfName(format: String): String = format 
match {
    +    case "parquet" => "spark.sql.parquet.compression.codec"
    +    case "orc" => "spark.sql.orc.compression.codec"
    +  }
    +
    +  private def getTableCompressPropName(format: String): String = {
    +    format.toLowerCase match {
    +      case "parquet" => "parquet.compression"
    +      case "orc" => "orc.compress"
    +    }
    +  }
    +
    +  private def getTableCompressionCodec(path: String, format: String): 
String = {
    --- End diff --
    
    Change to getHiveCompressPropName, is it appropriate?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to