Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/2712#issuecomment-58387498
Great catch.
A concern is that calling Array#take requires an implicit conversion, which
has some performance impact that might be unacceptable for this method that can
get called in a tight loop.
http://villane.wordpress.com/2008/02/02/learning-scala-performance-impact-of-implicit-conversions/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
