Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19467#discussion_r144408406
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EnsureStatefulOpPartitioningSuite.scala
---
@@ -53,7 +53,7 @@ class EnsureStatefulOpPartitioningSuite extends
SparkPlanTest with SharedSQLCont
test("ClusteredDistribution with coalesce(1) generates Exchange with
HashPartitioning") {
testEnsureStatefulOpPartitioning(
baseDf.coalesce(1).queryExecution.sparkPlan,
- requiredDistribution = keys => ClusteredDistribution(keys),
--- End diff --
This test suite does not make sense as this rule does not exist anymore. So
if we add tests in the related PlannerSuite to test the new addition in
EnsureRequirements and Partitioning, then we will only need to test whether
each stateful operator specifies the numPartitions in its required distribution.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
