Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19486#discussion_r144448478
  
    --- Diff: 
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
 ---
    @@ -530,9 +531,11 @@ public void testOOMDuringSpill() throws Exception {
         // we expect an OutOfMemoryError here, anything else (i.e the original 
NPE is a failure)
         catch (OutOfMemoryError oom){
           String oomStackTrace = Utils.exceptionString(oom);
    -      assertThat("expected OutOfMemoryError in 
org.apache.spark.util.collection.unsafe.sort.UnsafeInMemorySorter.reset",
    +      assertThat("expected OutOfMemoryError in " +
    +              
"org.apache.spark.util.collection.unsafe.sort.UnsafeInMemorySorter.reset",
                   oomStackTrace,
    -              
Matchers.containsString("org.apache.spark.util.collection.unsafe.sort.UnsafeInMemorySorter.reset"));
    +              Matchers.containsString(
    +                  
"org.apache.spark.util.collection.unsafe.sort.UnsafeInMemorySorter.reset"));
    --- End diff --
    
    Wait .. @ash211, mind fixing these to double-spaced indentation?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to