Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19470#discussion_r144469314
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2050,4 +2050,64 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
}
}
}
+
+ Seq("orc", "parquet").foreach { format =>
+ test(s"SPARK-18355 Read data from a hive table with a new column -
$format") {
+ val client =
spark.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client
+
+ Seq("true", "false").foreach { value =>
+ withSQLConf(
+ HiveUtils.CONVERT_METASTORE_ORC.key -> value,
+ HiveUtils.CONVERT_METASTORE_PARQUET.key -> value) {
--- End diff --
As you separate orc and parquet to two test in fact, maybe you just need to
test against one config at one time, i.e., orc ->
HiveUtils.CONVERT_METASTORE_ORC, parquet ->
HiveUtils.CONVERT_METASTORE_PARQUET.key.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
